[wp-trac] [WordPress Trac] #56444: Remove rel="nofollow" from internal links in comments

[WordPress Trac]

#56444: Remove rel="nofollow" from internal links in comments
------------------------------------------+---------------------
 Reporter:  benish74                      |       Owner:  (none)
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  6.2
Component:  Comments                      |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+---------------------
Changes (by thomasplevy):

 * keywords:  has-patch has-unit-tests => needs-patch needs-unit-tests


Comment:

 I opened a PR (https://github.com/WordPress/wordpress-develop/pull/3825)
 for review with an alternate patch to address this issue.

 It also, I think, addressed the issues raised in #53290

 I think it addresses all the concerns and I think I have it well covered
 with tests. I did add a new "helper" function. I was trying my best to
 repeat as little code as possible across the modified functions and
 creating a new helper seemed the best way to do this, but I'm not sure
 I've implemented this in the best way possible: does it belong in this
 file? Should it be "private" (as I've made it) with a leading underscore?
 Should it not exist at all? Is it well named? Etc...

 Looking for feedback if this patch would be a good way to address these
 problems. If it's good to go I'll convert to a patch and attach here.

 Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56444#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform