[wp-trac] [WordPress Trac] #45795: Twenty Nineteen: missing license information for assets

[WordPress Trac]

#45795: Twenty Nineteen: missing license information for assets
---------------------------+-----------------------------
 Reporter:  poena          |       Owner:  williampatton
     Type:  defect (bug)   |      Status:  assigned
 Priority:  high           |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------------

Comment (by sabernhardt):

 I would prefer replacing many icons, but I made a PR in case that might be
 enough for now. It assumes Twenty Nineteen's use of icons is acceptable
 and includes (some) more license information to help determine whether
 works based on the theme may not fit the licenses.

 ==== Material Design icons by Google

 I compared the paths against the 3.0.1 branch of the
 [https://github.com/google/material-design-icons Material Design
 repository] (first checking the `production` directory, though some
 matched `design`). Most of these have been updated since 2016.

 Discrepancies compared to Twenty Nineteen:
 1. The encircled down arrow matches `arrow_circle_down`, not
 `arrow_drop_down_circle`.
 2. The `comment` icon matches the Material Design icon's dimensions but
 does not have the inner (speech) lines.
 3. The icon under `keyboard_arrow_left` matches the ''current''
 `arrow_left`.
 4. The icon under `keyboard_arrow_right` matches the ''current''
 `arrow_right`.
 5. The `watch_later` icon name simply needs an underscore instead of a
 hyphen.

 Copyright years (2014-2023):
 - [https://github.com/google/material-design-icons/releases/tag/1.0.0
 first release in 2014]
 - [https://github.com/google/material-design-icons/releases/tag/4.0.0
 4.0.0 released in 2020]
 - [https://github.com/google/material-design-
 icons/commit/511eea577b20d2b02ad77477750da1e44c66a52c readme updated] on
 GitHub this year

 ==== Custom icons

 Trac has the following notice when uploading attachments to a ticket: "By
 contributing code to WordPress, you grant its use under the GNU General
 Public License v2 (or later)." I did not find a similar notice in
 CONTRIBUTING.md, but I expect any direct contributions to the theme on
 GitHub should fall under the same license.

 1. Kjell Reigstad's custom `arrow_drop_down_ellipsis` icon is used in
 `twentynineteen_add_ellipses_to_nav`
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/inc/template-functions.php?rev=53236#L138
 menu function]. @kjellr
 [https://github.com/WordPress/twentynineteen/pull/485/commits/dfe502b9eb175609bc495e747b267ea6dd4c3573
 #diff-0a741e5206ea59256fd0a0243d3f9bfb3dbd408963b08ed55272567013b40885
 added one version], and it was modified and moved before merging
 [https://github.com/WordPress/twentynineteen/pull/485 PR 485].
 2. Toni Laakso's Last.fm icon was added in
 [https://github.com/WordPress/twentynineteen/pull/472 PR 472].

 ==== Social Logos

 Most icons in the social array seem to come from
 [https://github.com/Automattic/social-
 logos/tree/f38f9f923c4b5ec48c5f4c851617f79351451bbe/sources/svg
 Automattic's Social Logos]. 28 of the theme's 43 social icons match the
 paths from the ''un-minified'' SVG collection as of 2018.

 Discrepancies compared to Twenty Nineteen:
 1. The repo does not include `500px`, `apple`, `bandcamp`, `chain`,
 `deviantart`, `digg`, `etsy`, `goodreads`, `meetup`, `slideshare`,
 `snapchat`, `soundcloud`, `vk`, `yelp`, or (as expected) the custom
 `lastfm` icon.

 Copyright years (2015-2023):
 - [https://github.com/Automattic/social-
 logos/commit/614b4c79c37099723c6e6cb9c2b3eca5e9db4cd0 initial commit in
 2015]
 - [https://github.com/Automattic/social-logos/pull/115 GitHub has an
 update for the Mastodon icon] this year

 ==== WordPress Social Link Block

 Gutenberg PR 16897 specifically mentions
 [https://github.com/WordPress/gutenberg/pull/16897#issuecomment-518304419
 Social Logos as a possible source].
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentytwenty/readme.txt?rev=55413#L133 Twenty Twenty
 credits] the WordPress Social Link Block for its logos because that theme
 [https://github.com/WordPress/twentytwenty/pull/933 intentionally matched
 the block]. Updating Twenty Nineteen icons to match the block and Twenty
 Twenty (as much as possible) would be good.

 Discrepancies compared to Twenty Nineteen:
 1. The block has a [https://github.com/Automattic/social-logos/blob/trunk
 /svg-min/facebook.svg newer version of the Facebook logo], which I found
 in the current Social Logos.
 2. Reddit and Tumblr have a different SVG in the current Social block, but
 I did not find matches to those in the Social Logos repo.
 3. The
 [https://github.com/WordPress/gutenberg/pull/16897/commits/6e6f3f12cc348f72cff55f4038ba404019220db2
 first commit with icons] toward the block's PR 16897 had exactly the same
 paths as the icons in Twenty Nineteen, though Google Plus was not included
 in the PR. Apple, Digg, SlideShare and StumbleUpon icons were removed
 before merging.

 For more information, I made a [https://docs.google.com/spreadsheets/d
 /1YVprL-q_Qy4HRnZNz7ORPM2Kc8W8v4B8HBi1rMHM3uY/edit?usp=sharing Google
 Sheet to compare the icon sets].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45795#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform