[wp-trac] [WordPress Trac] #57320: Revisions: add filter before deleting revisions

WordPress Trac noreply at wordpress.org
Wed Feb 22 20:47:52 UTC 2023


#57320: Revisions: add filter before deleting revisions
-------------------------------------------------+-------------------------
 Reporter:  jhned                                |       Owner:
                                                 |  johnbillion
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2
Component:  Revisions                            |     Version:
 Severity:  trivial                              |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note changes-requested commit                  |  administration
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55406" 55406]:
 {{{
 #!CommitTicketReference repository="" revision="55406"
 Revisions: Remove an unnecessary call to `_doing_it_wrong()` and
 corresponding new text string from the implementation of the new
 `wp_save_post_revision_revisions_before_deletion` filter.

 While the guard condition was technically correct, it's not practical or
 necessary to provide this protection for every use of every filter, and it
 adds unnecessary burden to translators to provide translations for strings
 that will likely not be seen.

 Follow up to [55254].

 Fixes #57320
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57320#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list