[wp-trac] [WordPress Trac] #60074: Add New Media File > The ''dismiss button ''not showing any response when uploading the unsupported (.jfif) file

WordPress Trac noreply at wordpress.org
Fri Dec 15 16:49:37 UTC 2023


#60074: Add New Media File > The ''dismiss button ''not showing any response when
uploading the unsupported (.jfif) file
--------------------------+------------------------------
 Reporter:  vivekawsm     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  6.4.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  has-patch => needs-patch


Comment:

 @mijotj - that is much closer and what I though about trying at first as
 well. Unfortunately the  plupload code (and everything in that vendor
 file) are upstream dependencies - meaning they are pulled in during our
 build file and we can't edit them directly - the changes would be
 overwritten during the build.

 I guess because we can't edit that file, we can't depend on it closing the
 error. Therefore we need to put the handler somewhere else. since we only
 use this when an error shows and its a tiny snippet, inlining it seems
 appropriate.

 The current code seems to be stripping the html added to the tag, maybe we
 can just add it immediately after the tag?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60074#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list