[wp-trac] [WordPress Trac] #54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if it grows (20MB in our case)

WordPress Trac noreply at wordpress.org
Thu Aug 31 17:28:10 UTC 2023


#54221: _transient_dirsize_cache is set to autoload=yes and kills db performance if
it grows (20MB in our case)
-------------------------------------+-------------------------------------
 Reporter:  archon810                |       Owner:  spacedmonkey
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  6.4
Component:  Database                 |     Version:  2.8
 Severity:  major                    |  Resolution:
 Keywords:  has-patch changes-       |     Focuses:  administration,
  requested                          |  performance
-------------------------------------+-------------------------------------

Comment (by flixos90):

 I like your latest suggestion @spacedmonkey and
 [attachment:"dirsize_expiration.patch"] that you implemented @nicomollet.
 Two follow-up comments:
 * Why do we set the expiration to `0` (none) when `wp_installing()`?
 * The `$expiration` variable definition in the `clean_dirsize_cache()`
 function should be moved below the early return if clause.

 I'd say this is ''almost'' good to commit :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54221#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list