[wp-trac] [WordPress Trac] #59241: get_the_posts_navigation wrong functions called for prev and next links

WordPress Trac noreply at wordpress.org
Wed Aug 30 19:11:12 UTC 2023


#59241: get_the_posts_navigation wrong functions called for prev and next links
--------------------------------+------------------------------
 Reporter:  valentinwebdev2019  |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Posts, Post Types   |     Version:  6.3.1
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+------------------------------

Comment (by valentinwebdev2019):

 Replying to [comment:2 SergeyBiryukov]:
 > Hi there, welcome to WordPress Trac! Thanks for the ticket.
 >
 > This was previously discussed in #55751, and some unit tests were added
 in [55429] and [55442]. It appears that the existing code is correct, as
 those tests fail with the changes from this PR.


 Hello,
 Thank you for taking the time to review my ticket.

 I think that initially the problem was caused by the desire to bind the
 work of the function to the context.
 The function actually outputs the links to switch the page number, and the
 context should be given by the name of the links and not by the function
 implementation.

 It seems to me that my last changes will help to eliminate confusion, at
 least in the code.
 Tests pass successfully

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59241#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list