[wp-trac] [WordPress Trac] #59185: Remove the Unused global variables in the wp-includes folder.

WordPress Trac noreply at wordpress.org
Mon Aug 28 14:43:51 UTC 2023


#59185: Remove the Unused global variables in the wp-includes folder.
--------------------------+-------------------------------
 Reporter:  upadalavipul  |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  6.4
Component:  General       |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Hi there, thanks for the patches!

 Looking at [attachment:"59185.2.patch"], I don't think those variables
 should be removed, as they are explicitly globalized for use in theme
 templates, and removing them would break backward compatibility. For
 reference, `load_template()` was introduced in [1910].

 So I believe this is fixed by [56477] and [56480].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59185#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list