[wp-trac] [WordPress Trac] #58657: Add in missing caching to `get_item_schema` method to new endpoint

WordPress Trac noreply at wordpress.org
Thu Aug 24 18:28:54 UTC 2023


#58657: Add in missing caching to `get_item_schema` method to new endpoint
--------------------------+---------------------------
 Reporter:  spacedmonkey  |       Owner:  spacedmonkey
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  6.3.2
Component:  REST API      |     Version:  5.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  performance
--------------------------+---------------------------

Comment (by kadamwhite):

 My memory is that we felt at the time like the caching was unnecessary
 because it would already be in place at a higher level, but I don't
 personally see any downside to having added it -- it feels like a micro-
 optimization with uncertain payoff, which is not worth having one or two
 controllers work different from all the others. @johnjamesjacoby called me
 out on the comment at the time and I now agree that the uncertainty it
 introduces is not good.

 @TimothyBlynJacobs My instinct is to remove the comment and leave the
 caching in place as-is, but I would like a second opinion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58657#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list