[wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute

WordPress Trac noreply at wordpress.org
Thu Aug 24 15:19:42 UTC 2023


#45950: Twenty Nineteen: Fix social media icons to use the correct height & width
attribute
-------------------------------------------------+-------------------------
 Reporter:  crunnells                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:  5.0.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots good-first-bug has-  |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------

Comment (by JordanPak):

 @tahmidulkarim I tested this patch and created an updated pull request for
 it: https://github.com/WordPress/wordpress-develop/pull/5060. LGTM.

 == Test Report
 This report validates that the indicated patch addresses the issue.

 Patch tested:
 https://core.trac.wordpress.org/attachment/ticket/45950/45950.diff

 === Environment
 - OS: Linux 5.15.49-linuxkit-pr x86_64
 - Web Server: nginx/1.25.2
 - PHP: 7.4.33
 - WordPress: 6.4-alpha-56267-src
 - Browser: Chrome 115, FireFox 115, Safari 15.6.1
 - Theme: Twenty Nineteen
 - Active Plugins: None

 === Actual Results
 ✅ Issue resolved with patch. Inline `<svg>` width and height attributes
 are `32`, which matches the dimensions applied with CSS.

 === Automated Test Results
 I created [https://github.com/WordPress/wordpress-develop/pull/5060 an
 updated PR to run automated tests/actions] and they all passed except a
 [https://github.com/WordPress/wordpress-
 develop/actions/runs/5965248175/job/16182261843?pr=5060 seemingly
 unrelated PHP 7.4 + Multisite + MySQL 8 test].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45950#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list