[wp-trac] [WordPress Trac] #59161: Composer: update to WordPressCS 3.0.0
WordPress Trac
noreply at wordpress.org
Mon Aug 21 17:53:20 UTC 2023
#59161: Composer: update to WordPressCS 3.0.0
------------------------------+-------------------------------
Reporter: jrf | Owner: SergeyBiryukov
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.4
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: coding-standards
------------------------------+-------------------------------
Comment (by jrf):
Replying to [comment:8 jrf]:
> @desrosj Did I forget to do that ? Oops... It doesn't have to be (as
sniffs are supposed to give the same results on all supported PHP
versions), but it definitely can be. If so, I suggest setting it to
`'latest'` to allow `setup-php` to auto-update the version (and yes, WPCS
3.0.0 works fine on PHP 8.3, so we should be good for at least a year and
a half).
@desrosj Looking at the workflow now, but if I look at the
`branches`/`tags` settings, I get the impression that workflow is also
used with older WP (backport) releases. If so, then no, we should **not**
change the PHP version in the workflow as older WP versions will not get
the update to WPCS 3.0.0, so those may still run into PHP 8.x issues when
using WPCS 2.3.0, which would break builds.
Does that make sense ?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59161#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list