[wp-trac] [WordPress Trac] #56431: Fatal Error on Update Page When a Plugin's Icon is Not Set

[WordPress Trac]

#56431: Fatal Error on Update Page When a Plugin's Icon is Not Set
-------------------------------------------------+-------------------------
 Reporter:  scott.deluzio                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch needs-testing dev-       |     Focuses:
  feedback reporter-feedback                     |
-------------------------------------------------+-------------------------

Comment (by costdev):

 Hey @hellofromTonya! The issues is the `icons` property. If an extender
 messes up and uses an object, this will cause a fatal.

 Normally we'd tell extenders to do it right and we'd move on. However, if
 I installed Plugin A 1.0.0 and version 2.0.0 mistakenly uses an object for
 its icons, then without that version even being installed, it can cause a
 fatal on WordPress sites.

 I think we could both protect users from pending updates causing fatal
 errors, while also notifying the extenders via a
 `_doing_it_wrong()`/`trigger_error()` behind `WP_DEBUG`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56431#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform