[wp-trac] [WordPress Trac] #58910: Reconsider wp_add_fields_to_navigation_fallback_embedded_links() location

WordPress Trac noreply at wordpress.org
Wed Aug 2 20:57:06 UTC 2023


#58910: Reconsider wp_add_fields_to_navigation_fallback_embedded_links() location
--------------------------------------+-----------------------
 Reporter:  SergeyBiryukov            |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  6.3
Component:  Editor                    |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+-----------------------

Comment (by ramonopoly):

 > This was the original approach we wanted to take

 Thanks for digging up the context @scruffian it’s really helpful.

 I’m happy with either way. If we keep the hook, maybe we should rename it
 as it seems to affect all the wp_navigation post objects and not just the
 one returned by the fallback embedded link?

 Then I guess we should answer whether to create a new file and where it
 should live 👍


 > there is a non-zero amount of irony in the replacing "a new file with a
 single function"

 The irony isn’t lost on me :-) but what would life be without it 🤷‍♀️ha

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58910#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list