[wp-trac] [WordPress Trac] #58935: White page on admin.php in WordPress Dashboard
WordPress Trac
noreply at wordpress.org
Tue Aug 1 18:47:28 UTC 2023
#58935: White page on admin.php in WordPress Dashboard
-------------------------------------+------------------------------
Reporter: masoudin | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: administration
-------------------------------------+------------------------------
Comment (by masoudin):
Replying to [comment:4 peterwilsoncc]:
Thank you, @peterwilsoncc.
@rajinsharwar
I believe you should refactor your pull request and handle what
@peterwilsoncc mentioned.
> At the end of `admin.php` WordPress fires a custom action for requests
that include either `$_GET['action']` or `$_POST['action']`
[https://github.com/WordPress/wordpress-
develop/blob/6837a90e49e82192224472ac35fe2a9cc7a9e2ac/src/wp-
admin/admin.php#L408-L420 (code reference)].
>
> The firing of this action does not require a query string parameter to
be set, as such making this change would need to consider backward
compatibility for plugins POSTing an action to `/wp-admin/admin.php`
without a query string component.
>
> As a proof of concept, I've created a
[https://gist.github.com/peterwilsoncc/cef6473cc0cb449fddd8438e4fa9e5b8
mini-plugin] to demonstrate the use of `admin.php` without a query string
parameter.
>
> @masoudin You are correct that the user experience could be nicer for
people visiting `admin.php` without any form data (either via POST or GET)
but the existing pull request will require a little refactoring to ensure
that backward compatibility is retained.
>
> I've removed the version from this ticket as enhancements don't require
a version be specified.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58935#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list