[wp-trac] [WordPress Trac] #56604: Dark blue closing cross over the black background in plugins page

[WordPress Trac]

#56604: Dark blue closing cross over the black background in plugins page
-------------------------------------+-------------------------------------
 Reporter:  dperonne                 |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  6.2
Component:  Plugins                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  ui, accessibility,
  patch changes-requested            |  css, administration
-------------------------------------+-------------------------------------
Changes (by sabernhardt):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch changes-
     requested


Comment:

 Thanks for the patch!

 I do not think changing the button's position is necessary, unless we
 replace the entire Thickbox dialog with a new one similar to the Theme
 details.

 The light gray icon color in the patch does not work as a hover/focus
 style because that matches the un-focused style. Using
 [https://codepen.io/ryelle/full/WNGVEjw "Blue 10"] (`#9ec2e6`) would stand
 out better than the dark blue, but the focus style ideally would be more
 obvious than only changing the color.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56604#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform