[wp-trac] [WordPress Trac] #56008: Twenty Sixteen: Pullquote Block: Color not reflected in editor and front end

[WordPress Trac]

#56008: Twenty Sixteen: Pullquote Block: Color not reflected in editor and front
end
---------------------------------------+----------------------
 Reporter:  nithins53                  |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  6.1
Component:  Bundled Theme              |     Version:  6.0
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, css
---------------------------------------+----------------------

Comment (by poena):

 Hi,
 I have tested patch 56008.1.

 WordPress 6.1-beta2-54351: both the default color and custom color (text
 and background) works well for me in the editor and the front.

 5.9.4:
 The default and custom text colors are correct on the front.

 Background colors selected from the palette does not show on the front.
 Background colors selected with the color picker, does show on the front
 since the color is inline.

 I don't fully understand why, but WordPress
 sets the background color to none:
 {{{
 .wp-block-pullquote:not(.is-style-solid-color) {
     background: none;
 }
 }}}
 The theme could solve this with a higher specificity, targeting the has-
 background class.

 In the editor, the cite is the default color even if a custom text color
 is selected.
 I believe the difference is that in 5.9.4, the citation text is not in an
 actual
 {{{cite}}} element but in a div.
 This should be solvable by adding {{{.wp-block-pullquote__citation}}}
 The markup in the editor is:


 {{{
 <figure class="block-editor-block-list__block wp-block has-border-color
 has-bright-red-border-color has-bright-blue-color has-yellow-background-
 color has-text-color has-background is-selected wp-block-pullquote" id
 ="block-a3c0d349-3b27-4ecb-ad67-90f27ef5ecff" tabindex="0" role="document"
 aria-label="Block: Pullquote" data-block="a3c0d349-3b27-4ecb-
 ad67-90f27ef5ecff" data-type="core/pullquote" data-title="Pullquote" style
 ="border-color: rgb(255, 103, 95); color: rgb(0, 122, 204); background-
 color: rgb(255, 239, 142);">
 <blockquote><div role="textbox" aria-multiline="true" aria-
 label="Pullquote text" class="block-editor-rich-text__editable rich-text"
 style="white-space: pre-wrap; min-width: 1px;"
 contenteditable="true"><p>quote text</p></div>
 <div role="textbox" aria-multiline="true" aria-label="Pullquote citation
 text" class="block-editor-rich-text__editable wp-block-pullquote__citation
 rich-text" style="white-space: pre-wrap; min-width: 1px;"
 contenteditable="true">cite</div>
 </blockquote>
 </figure>
 }}}


 So again it depends on which WP version we are fixing it for. If it is
 enough to solve it in 6.1, then the patch is ready in my opinion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56008#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform