[wp-trac] [WordPress Trac] #55883: Reverse wrapping of `apply_shortcodes()` and `do_shortcode()`

WordPress Trac noreply at wordpress.org
Mon Sep 26 21:41:24 UTC 2022


#55883: Reverse wrapping of `apply_shortcodes()` and `do_shortcode()`
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.1
Component:  Shortcodes                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-docs has-patch add-to-field-   |     Focuses:
  guide 2nd-opinion revert                       |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:23 JeffPaul]:

 No, [54278] was a partial revert to fix a regression. What I meant is to
 revert the whole "rename" of `do_shortcode()` to `apply_shortcodes()` as
 committed in [54248]. Imho it is not good to break all existing references
 (38k in plugins and about 263k on Google) to the old name, as it is not
 that bad. The confusion of these broken references far outweighs any
 possible benefits of renaming. The partial revert seems to have made this
 even more confusing.

 Another reason for full revert would be that "apply shortcodes" doesn't
 describe properly what that function does. It does search and replace, and
 in English you usually cannot say "apply search and replace". The proper
 way to say that would be to "do search and replace". Maybe not such a big
 deal, but why not use good English :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55883#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list