[wp-trac] [WordPress Trac] #54736: get_sample_permalink unsets $post->filter even though this is a public property.

[WordPress Trac]

#54736: get_sample_permalink unsets $post->filter even though this is a public
property.
----------------------------------------+-----------------------------
 Reporter:  herregroen                  |       Owner:  hellofromTonya
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  6.1
Component:  Posts, Post Types           |     Version:  2.7.1
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------
Changes (by peterwilsoncc):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"54244" 54244]:
 {{{
 #!CommitTicketReference repository="" revision="54244"
 Posts, Post types: Prevent `get_sample_permalink()` modifying the post
 object.

 `get_sample_permalink()` (ab)uses the `$post->filter` property to indicate
 a sample permalink is being generated for the post. This change ensures
 the property is restored to its original value.

 Props herregroen, hellofromTonya, peterwilsoncc, Rahmohn, costdev.
 Fixes #54736.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54736#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform