[wp-trac] [WordPress Trac] #56566: Fatal error when WP_REST_Server::dispatch() returns WP_Error

[WordPress Trac]

#56566: Fatal error when WP_REST_Server::dispatch() returns WP_Error
--------------------------------------+--------------------------------
 Reporter:  DaveFX                    |       Owner:  TimothyBlynJacobs
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  6.1
Component:  REST API                  |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+--------------------------------

Comment (by felipeelia):

 @TimothyBlynJacobs I've created the PR above adding PHPUnit tests for the
 fix created by @DaveFX  (thanks, Dave!)

 The PR also fixes the `test_link_embedding_without_links` test, which was
 effectively testing nothing. As `embed_links` is a protected function, I'm
 testing it through `response_to_data`, as we are doing in some other
 places.

 Let me know if any adjustment is needed. Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56566#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform