[wp-trac] [WordPress Trac] #56574: Docs: Wrong parameter type used for Walker_Nav_Menu class

[WordPress Trac]

#56574: Docs: Wrong parameter type used for Walker_Nav_Menu class
---------------------------------------------+------------------------
 Reporter:  dilipbheda                       |       Owner:  audrasjb
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  6.1
Component:  Menus                            |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch commit good-first-bug  |     Focuses:  docs
---------------------------------------------+------------------------

Comment (by robinwpdeveloper):

 My conclusion is existing code is alright!

 Here all 4 param descriptions are for the filter.
 First value of the filter is
 {{{
 'menu-item-' . $menu_item->ID
 }}}

 So, $menu_id is passed as string to the filter.

 I haven’t tested the code by using the filter though.

 Please correct me if I am wrong.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56574#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform