[wp-trac] [WordPress Trac] #50191: Propose https prefix, not http for external links

WordPress Trac noreply at wordpress.org
Fri Sep 9 13:31:36 UTC 2022


#50191: Propose https prefix, not http for external links
-------------------------------------------------+-------------------------
 Reporter:  casiepa                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch 2nd-        |     Focuses:  ui-copy
  opinion                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch 2nd-
               opinion


Comment:

 This one seems to be a bit more involved than just simply changing these
 two strings. Those strings are copied directly from the TinyMCE library
 and included here for translation purposes. I believe that changing them
 in `class-wp-editor.php` without changing them in TinyMCE would result in
 those strings no longer being translated properly.

 TinyMCE is currently on version 6.2, and WordPress includes 4.9.11 (last
 updated in [49557]). And far as I can tell, the 4.x branch is no longer
 maintained upstream, and we have not made any changes to the version of
 the library included in Core.

 We ''could'' make changes to the bundled version on a case by case basis.
 But it would make it much more difficult to merge in an update from the
 maintainers should one become available (though unlikely). While this
 change does make sense (HTTPS is the
 [https://w3techs.com/technologies/details/ce-httpsdefault protocol used on
 80%+ of websites now]), I'm not sure that it's worth the effort.
 Especially where WordPress no longer uses this library by default.

 @azaozz Do you have any thoughts here?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50191#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list