[wp-trac] [WordPress Trac] #55656: PHP 8.x: various compatibility fixes for WordPress 6.1

[WordPress Trac]

#55656: PHP 8.x: various compatibility fixes for WordPress 6.1
-------------------------------------------------+-------------------------
 Reporter:  hellofromTonya                       |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  6.1
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 php81 has-patch has-unit-tests  |     Focuses:  coding-
                                                 |  standards
-------------------------------------------------+-------------------------

Comment (by jrf):

 The builds against PHP 8.1 are still allowed to "continue on error" as
 there are still (known) incompatibilities with PHP 8.1 which impact the
 tests.

 As PHP 8.2 is on the horizon and
 [https://core.trac.wordpress.org/ticket/56009 fixes are being created to
 make WP compatible with PHP 8.2], the above would mean that builds against
 PHP 8.2 would also need to "continue on error" due to the PHP 8.1 issues,
 even when there would be no PHP 8.2 issues.

 All in all, the risk of new PHP 8.1 + 8.2 issues being introduced without
 anyone noticing grows exponentially this way.

 With that in mind, a renewed effort has been made to fix (some of) the
 remaining PHP 8.1 issues which impact the test runs.

 Ultimately, the goal is to get a passing build for PHP 8.1 (and 8.2),
 notwithstanding that we know that there are still additional issues to be
 solved which are currently not or insufficiently covered by tests.


 So, with that in mind, I've opened six new PRs related to this ticket:
 * [https://github.com/WordPress/wordpress-develop/pull/3181 GH PR #3181 -
 GH Actions vs PHP 8.1 tweaks]
 * [https://github.com/WordPress/wordpress-develop/pull/3184 GH PR #3184 -
 PHP 8.1 | WP_Customize_Manager::get_return_url(): bug fix]
 * [https://github.com/WordPress/wordpress-develop/pull/3185 GH PR #3185 -
 PHP 8.1 | WP_Scripts::localize(): fix autovivification from false to array
 bug]
 * [https://github.com/WordPress/wordpress-develop/pull/3186 GH PR #3186 -
 PHP 8.1 | load_script_textdomain(): fix passing null to non-nullable]
 * [https://github.com/WordPress/wordpress-develop/pull/3187 GH PR #3187 -
 PHP 8.1 | wp_xmlrpc_server::(mw_newPost|_insert_post)(): fix passing null
 to non-nullable and more]
 * [https://github.com/WordPress/wordpress-develop/pull/3188 GH PR #3188 -
 PHP 8.1 | WP_REST_Users_Controller::update_item(): fix passing null to
 non-nullable]

 Reviews/merges appreciated ;-)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55656#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform