[wp-trac] [WordPress Trac] #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering

[WordPress Trac]

#16502: Quick Edit contents should only be rendered if quick edit button in actions
after filtering
-------------------------------------------------+-------------------------
 Reporter:  wyrfel                               |       Owner:  chriscct7
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  6.1
Component:  Quick/Bulk Edit                      |     Version:  3.0.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info changes-requested                 |  performance
-------------------------------------------------+-------------------------

Comment (by mukesh27):

 Thanks for the test report and feedback, @costdev.

 As requested, I implemented the changes for the category and tags. I also
 tried to comment and got an error in the unit test for Ajax.

 {{{
 1) Tests_Ajax_EditComment::test_as_admin
 Undefined index: hook_suffix

 /var/www/src/wp-admin/includes/class-wp-screen.php:223
 /var/www/src/wp-admin/includes/template.php:2601
 /var/www/src/wp-admin/includes/class-wp-list-table.php:149
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:55
 /var/www/src/wp-admin/includes/list-table.php:61
 /var/www/src/wp-admin/includes/template.php:446
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:872
 /var/www/src/wp-admin/includes/class-wp-list-table.php:1455
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:644
 /var/www/src/wp-admin/includes/ajax-actions.php:1477
 /var/www/src/wp-includes/class-wp-hook.php:307
 /var/www/src/wp-includes/class-wp-hook.php:331
 /var/www/src/wp-includes/plugin.php:517
 /var/www/tests/phpunit/includes/testcase-ajax.php:265
 /var/www/tests/phpunit/tests/ajax/EditComment.php:62
 phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:51

 2) Tests_Ajax_EditComment::test_editor_can_edit_orphan_comments
 Undefined index: hook_suffix

 /var/www/src/wp-admin/includes/class-wp-screen.php:223
 /var/www/src/wp-admin/includes/template.php:2601
 /var/www/src/wp-admin/includes/class-wp-list-table.php:149
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:55
 /var/www/src/wp-admin/includes/list-table.php:61
 /var/www/src/wp-admin/includes/template.php:446
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:872
 /var/www/src/wp-admin/includes/class-wp-list-table.php:1455
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:644
 /var/www/src/wp-admin/includes/ajax-actions.php:1477
 /var/www/src/wp-includes/class-wp-hook.php:307
 /var/www/src/wp-includes/class-wp-hook.php:331
 /var/www/src/wp-includes/plugin.php:517
 /var/www/tests/phpunit/includes/testcase-ajax.php:265
 /var/www/tests/phpunit/tests/ajax/EditComment.php:110
 phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:51

 3) Tests_Ajax_GetComments::test_as_admin
 Undefined index: hook_suffix

 /var/www/src/wp-admin/includes/class-wp-screen.php:223
 /var/www/src/wp-admin/includes/template.php:2601
 /var/www/src/wp-admin/includes/class-wp-list-table.php:149
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:55
 /var/www/src/wp-admin/includes/list-table.php:61
 /var/www/src/wp-admin/includes/template.php:446
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:872
 /var/www/src/wp-admin/includes/class-wp-list-table.php:1455
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:644
 /var/www/src/wp-admin/includes/ajax-actions.php:1265
 /var/www/src/wp-includes/class-wp-hook.php:307
 /var/www/src/wp-includes/class-wp-hook.php:331
 /var/www/src/wp-includes/plugin.php:517
 /var/www/tests/phpunit/includes/testcase-ajax.php:265
 /var/www/tests/phpunit/tests/ajax/GetComments.php:59
 phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:51

 4) Tests_Ajax_ReplytoComment::test_as_admin
 Undefined index: hook_suffix

 /var/www/src/wp-admin/includes/class-wp-screen.php:223
 /var/www/src/wp-admin/includes/template.php:2601
 /var/www/src/wp-admin/includes/class-wp-list-table.php:149
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:55
 /var/www/src/wp-admin/includes/list-table.php:61
 /var/www/src/wp-admin/includes/template.php:446
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:872
 /var/www/src/wp-admin/includes/class-wp-list-table.php:1455
 /var/www/src/wp-admin/includes/class-wp-comments-list-table.php:644
 /var/www/src/wp-admin/includes/ajax-actions.php:1403
 /var/www/src/wp-includes/class-wp-hook.php:307
 /var/www/src/wp-includes/class-wp-hook.php:331
 /var/www/src/wp-includes/plugin.php:517
 /var/www/tests/phpunit/includes/testcase-ajax.php:265
 /var/www/tests/phpunit/tests/ajax/ReplytoComment.php:73
 phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:51
 }}}


 I found a similar error report #29933 If I make these changes, it will
 resolve my unit test errors. @SergeyBiryukov, could you please help me
 with this?

 {{{
 /wp-admin/includes/class-wp-screen.php on line 223

 $id = $GLOBALS['hook_suffix'];
 Replace with
 $id = isset($GLOBALS['hook_suffix']) ? $GLOBALS['hook_suffix'] : "";
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/16502#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform