[wp-trac] [WordPress Trac] #56199: Make the warnings about critical Site Health issues more prominent

[WordPress Trac]

#56199: Make the warnings about critical Site Health issues more prominent
-----------------------------------------------+---------------------
 Reporter:  azaozz                             |       Owner:  (none)
     Type:  enhancement                        |      Status:  new
 Priority:  normal                             |   Milestone:  6.1
Component:  Site Health                        |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  servehappy needs-design has-patch  |     Focuses:
-----------------------------------------------+---------------------

Comment (by Clorith):

 PR 3177 adds a bubble-count to the "Site Health" menu item, but ''not''
 the parent "Tools" one, the reasoning being that there's no clean way of
 doing this without the same kind of "hard coded" approach as is done to
 add the counter to the sub-menu item within core.

 I think re-visiting the parent menu item item is something that could be
 done in a future iteration, when a system for managing badges/bubbles
 within menu items in general is unified.

 As for the implementation it self, it's basically taking the transient
 data that the dashboard widget also uses, and adds the counter based on
 the amount of `critical` issues, as described. The one place where the
 behavior ''might'' feel a bit strange, is when you click into the Site
 Health screen, since the badge is reactive to the status checks, it may
 disappear, and re-appear once the tests have re-ran (since the test suite
 starts with `0` issues, before it starts processing them and getting
 asynchronous test results back).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56199#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform