[wp-trac] [WordPress Trac] #55654: Tests: Reduce usage of assertEquals for 6.1

WordPress Trac noreply at wordpress.org
Mon Oct 10 15:57:27 UTC 2022


#55654: Tests: Reduce usage of assertEquals for 6.1
--------------------------------------+------------------------
 Reporter:  hellofromTonya            |       Owner:  desrosj
     Type:  task (blessed)            |      Status:  reviewing
 Priority:  normal                    |   Milestone:  6.1
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by SergeyBiryukov):

 In [changeset:"54446" 54446]:
 {{{
 #!CommitTicketReference repository="" revision="54446"
 Tests: Use `assertSame()` in some `WP_Theme_JSON` tests.

 This ensures that not only the return values match the expected results,
 but also that their type is the same.

 Previously committed in [54402], these instances appear to be accidentally
 reverted to `assertEquals()` in [54443].

 Follow-up to [52275], [54162], [54402], [54443].

 See #55654.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55654#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list