[wp-trac] [WordPress Trac] #56467: Update @wordpress packages and backport changes from Gutenberg plugin into Core
WordPress Trac
noreply at wordpress.org
Fri Oct 7 09:38:29 UTC 2022
#56467: Update @wordpress packages and backport changes from Gutenberg plugin into
Core
--------------------------------------+------------------------------
Reporter: Bernhard Reiter | Owner: Bernhard Reiter
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 6.1
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Comment (by audrasjb):
In [changeset:"54408" 54408]:
{{{
#!CommitTicketReference repository="" revision="54408"
Editor: Add missing `blocks` origin to `theme.json`.
This changeset updates the blocks origin name from core to blocks and adds
it to the list of valid origins for `theme.json`.
(See the original fix in [https://github.com//pull/3319 Gutenberg's PR
44363]).
Why?
- This new origin was missing from the list.
- The `core` name is not reflective of what it does, as this data origin
is related to block styles, whether they come with WordPress or third-
party blocks.
- The existing filter for this piece of data is called
`theme_json_blocks`, to reflect it filters "block" data.
- Though `core` origin was used in the past for `default`, this commit
reverts it. Why? It was confusing. The goal is to use names that
communicate what part of the pipeline are processing (`default > blocks >
theme > custom`).
How?
- Renames the string, from `core` to `blocks`.
- Adds `blocks` to the list of valid origins.
- Verifies that the `$theme_json->get_stylesheet()` call uses the proper
`$origins` at all times.
Follow-up to [54162], [54251].
Props oandregal, czapla, jorgefilipecosta, scruffian, bernhard-reiter
hellofromTonya.
See #56467.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56467#comment:293>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list