[wp-trac] [WordPress Trac] #56746: Unused function parameters in the class-wp-customize-background-image-setting.php files.

WordPress Trac noreply at wordpress.org
Thu Oct 6 12:54:36 UTC 2022


#56746: Unused function parameters in the class-wp-customize-background-image-
setting.php files.
-----------------------------+-------------------------------
 Reporter:  upadalavipul     |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  General          |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:  coding-standards
-----------------------------+-------------------------------
Changes (by jrf):

 * keywords:  has-patch => has-patch close


Comment:

 @upadalavipul There is a reason why that sniff is not applied to WP Core /
 in the `WordPress-Core` ruleset.

 WordPress is a highly extended package and overloaded (extended) versions
 of this class could be relying on this parameter.

 If it would be removed, it should also be removed from all method calls
 passing it and that would be considered a BC-break.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56746#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list