[wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1

WordPress Trac noreply at wordpress.org
Tue Oct 4 21:03:02 UTC 2022


#55652: Test tool and unit test improvements for 6.1
--------------------------------------+---------------------
 Reporter:  hellofromTonya            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.1
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by TobiasBg):

 @jrf: I can't seem to find the GH Actions run for my plugin where I had
 this problem, but I have some info from my commit message from the change:
  GitHub Actions: Use a different way for executing steps after a previous
 step errors.
  Using `continue-on-error` achieves the goal, but also lets jobs and
 workflows pass, which e.g.
  leads to the problem that the `failed-workflow` step is not executed.
  The `if` condition achieves this. Using `success() || failure()` over
 `always()` has the
  advantage that it still allows for builds to be cancelled.
 (I had been working on copying that `failed-workflow` enhancement that
 @desrosj added, as I'm often running into Github API issues, likely
 related to Composer.)

 Now, indeed, if `cs2pr` will give a non-0 exit code, things should
 actually be fine.
 I'll try again with my change reverted, to see if I can trigger the wrong
 behavior again.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55652#comment:197>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list