[wp-trac] [WordPress Trac] #55937: Salting functions: translate the phrase `put your unique phrase here`.

WordPress Trac noreply at wordpress.org
Sun Oct 2 22:41:21 UTC 2022


#55937: Salting functions: translate the phrase `put your unique phrase here`.
---------------------------+-----------------------
 Reporter:  peterwilsoncc  |       Owner:  audrasjb
     Type:  enhancement    |      Status:  reopened
 Priority:  normal         |   Milestone:  6.1
Component:  Security       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------

Comment (by peterwilsoncc):

 I've created an [https://github.com/WordPress/wordpress-develop/pull/3389
 alternative follow up pull request] that builds on @audrasjb's.

 In each location both the default English and default translated strings
 are considered duplicates, this matches the code in `wp_salt()`.

 This allows for site owners who download the English package and then
 switch language. I do wonder if the code should `switch_to_locale(
 $site_locale );` beforehand but I am not sure how much processing work
 that is.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55937#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list