[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

[WordPress Trac]

#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |
-------------------------------------------------+-------------------------

Comment (by jrf):

 Replying to [comment:82 azaozz]:
 > Replying to [comment:81 jrf]:
 > > Requests is still an EXTERNAL dependency.
 >
 > I think this is the big misconception here. Requests used to be an
 external dependency before it was moved from rmccue/Requests to
 WordPress/Requests. After moving there it became an internal
 dependency/library. In effect the WordPress project "forked" the Requests
 library to ensure it is maintained (if I remember right).

 Actually, no, this is not true.

 The repo was moved (not forked) - at my request - to lessen the risk of
 such a vital dependency for WordPress being locked in on someone's
 personal GH account, while that person no longer showed any interest in
 maintaining it.

 Personal accounts on GH can provide other people with commit rights -
 which both Alain and me already had by then -, but not with admin rights,
 which created a "one key to the castle" situation which is just plain
 risky for a project with the reach of Requests.

 That and that alone was the reason to look for a new home for the repo.

 Our hope was that with a move to the WP organisation, more WP
 committers/contributors would potentially get involved/show an interest,
 but so far that has not happened in any significant way and Alain and me
 (and an incidental outside contributor or two) remain the only active
 contributors/maintainers.

 It was never discussed nor implied that the status of the project as
 external dependency would change and in my opinion, it hasn't changed,
 we've just ensured that the "one key to the castle" risk was mitigated.


 > This actually brings another question: why does the Requests library use
 `WpOrg\` namespace? As @dd32
 [https://core.trac.wordpress.org/ticket/54504#comment:8 above] I'm a bit
 unsure if that's the best choice. Of course, as a project under the
 WordPress umbrella it can use any form of the WordPress name, but perhaps
 may be better to use `Requests\`, similarly to other PHP libraries? Any
 other opinions on that?


 Asked & answered before. The short answer is: technical reasons. See:
 https://core.trac.wordpress.org/ticket/54504?replyto=82#comment:12


 > (BTW, seems WP is using an older version of SimplePie which is not
 namespaced. The latest version seems to be using `namespace SimplePie;`
 which seems to be appropriate for a library.)

 See: https://core.trac.wordpress.org/ticket/55604

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:83>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform