[wp-trac] [WordPress Trac] #57167: Twenty Twenty-Three: Replace base and contrast color names with ref values
WordPress Trac
noreply at wordpress.org
Mon Nov 21 18:20:55 UTC 2022
#57167: Twenty Twenty-Three: Replace base and contrast color names with ref values
---------------------------+-----------------------------
Reporter: mikachan | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: normal | Keywords: 2nd-opinion
Focuses: |
---------------------------+-----------------------------
There have been previous discussions around the use of "base" and
"contrast" as color names in the Twenty Twenty-Three color palette, here:
https://github.com/WordPress/twentytwentythree/issues/36
I'd like to propose another idea that may help solve the naming issues,
especially around these two colors. We could define these two colors in
`styles.color.background` and `styles.color.text` instead of defining them
separately in the color palette. We could then use `ref` values to
reference them elsewhere in the theme.json files.
The colors can still be defined in the color palette, but perhaps under a
descriptive name, e.g. "dark purple". This means that the names of these
two colors in the color palette would not need to match their purpose
(e.g. background, foreground, base, contrast).
I've created a PR to demonstrate the idea.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57167>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list