[wp-trac] [WordPress Trac] #57002: safecss_filter_attr() removes the trailing semincolon

WordPress Trac noreply at wordpress.org
Wed Nov 16 22:48:05 UTC 2022


#57002: safecss_filter_attr() removes the trailing semincolon
--------------------------------------+----------------------
 Reporter:  Chouby                    |       Owner:  (none)
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:
Component:  Formatting                |     Version:  2.8.1
 Severity:  trivial                   |  Resolution:  wontfix
 Keywords:  has-patch has-unit-tests  |     Focuses:  css
--------------------------------------+----------------------
Changes (by peterwilsoncc):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 @hugod Thanks for understanding, yes, let's close this off without a fix
 for now

 To be clear, I absolutely agree with the premise that a trailing semi-
 colon would be best practice when `style="safecss_filter_attr( /*styles */
 )"`; the risk of ending up with two consecutive semi-colons results in a
 relative decision about the nicer code.

 Some choices require choosing the pragmatic over the ideal.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57002#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list