[wp-trac] [WordPress Trac] #57060: Always pass $locale to load_textdomain() if we know the locale

WordPress Trac noreply at wordpress.org
Thu Nov 10 13:28:02 UTC 2022


#57060: Always pass $locale to load_textdomain() if we know the locale
--------------------------+--------------------
 Reporter:  ocean90       |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  6.1.1
Component:  I18N          |    Version:  6.1
 Severity:  normal        |   Keywords:
  Focuses:  performance   |
--------------------------+--------------------
 In [53874] the optional `$locale` parameter was added to
 `load_textdomain()`. While most `load_textdomain()` calls in core were
 were updated, some were missed:

 * [https://github.com/WordPress/wordpress-
 develop/blob/302ba4f45f96490f5947f324228f20e0cbe28583/src/wp-
 includes/load.php#L1395-L1398 wp_load_translations_early()]
 * [https://github.com/WordPress/wordpress-
 develop/blob/551c3d6619b7e88742911ca2dd3aed77a71cb0dc/src/wp-
 includes/functions.php#L6354 wp_timezone_choice()]
 * [https://github.com/WordPress/wordpress-
 develop/blob/551c3d6619b7e88742911ca2dd3aed77a71cb0dc/src/wp-includes
 /rest-api/endpoints/class-wp-rest-site-health-controller.php#L339
 WP_REST_Site_Health_Controller::load_admin_textdomain()]
 * [https://github.com/WordPress/wordpress-
 develop/blob/551c3d6619b7e88742911ca2dd3aed77a71cb0dc/src/wp-
 admin/includes/admin.php#L16 wp-admin/includes/admin.php]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57060>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list