[wp-trac] [WordPress Trac] #57039: WP 6.1 - get_page_by_title(null) returns a page

WordPress Trac noreply at wordpress.org
Wed Nov 9 05:07:48 UTC 2022


#57039: WP 6.1 - get_page_by_title(null) returns a page
--------------------------------------+----------------------------
 Reporter:  stentibbing               |       Owner:  peterwilsoncc
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  6.1.1
Component:  Posts, Post Types         |     Version:  6.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------------

Comment (by TimothyBlynJacobs):

 I strongly agree that this should be reverted. We now have two separate
 issues which both don't have a super straightforward fix. Given that 6.1.1
 is being targeted for next week which will require a RC in the next few
 days, I don't think we should be doing another overhaul on this function
 in such a short period of time.

 > It goes from be cached to not being cached.

 True. But it was uncached in 6.0. I think it's unlikely that many
 developers have adopted this API in the past week. It's still
 [https://github.com/Automattic/VIP-Coding-
 Standards/blob/037fa4a3c4c6dac8e67b797afa2f04376732df0a/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php#L85
 restricted by VIP] for instance.

 > I don't see this bug as a big problem. This function was broken in pre
 6.1, as it was unpredictable to begin with.

 It's caused breakage for a number of users so far. It being unpredictable
 makes it a good candidate for deprecation in #57041. But if we are going
 to deprecate the function in the next release, then I don't think we
 should be committing an overhaul to the function right before.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57039#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list