[wp-trac] [WordPress Trac] #55711: Introduce a function to determine whether a function can be called. (was: set_time_limit( 300 ); in Class WP_Upgrader causes crashes in PHP8 when hosting disables it)

[WordPress Trac]

#55711: Introduce a function to determine whether a function can be called.
------------------------------+-----------------------------
 Reporter:  theode            |       Owner:  (none)
     Type:  task (blessed)    |      Status:  new
 Priority:  normal            |   Milestone:  6.1
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  php8 needs-patch  |     Focuses:  administration
------------------------------+-----------------------------
Changes (by costdev):

 * severity:  critical => normal
 * component:  Upgrade/Install => General
 * version:  5.9.3 =>
 * milestone:  Awaiting Review => 6.1
 * keywords:  php8 => php8 needs-patch
 * type:  defect (bug) => task (blessed)


Old description:

> Some hosting providers disable set_time_limit(). That is causing a fatal
> error when installing plugins, themes and import files under PHP8.
>
> My Suggestion is to prefix them all with an @ or remove them entirely.
>
> Reproducing. Not sure how to deactivate it for PHP8, but is an issue.
>
> Can't find a ticket, already stating this.

New description:

 Original title: set_time_limit( 300 ); in Class WP_Upgrader causes crashes
 in PHP8 when hosting disables it

 Some hosting providers disable set_time_limit(). That is causing a fatal
 error when installing plugins, themes and import files under PHP8.

 My Suggestion is to prefix them all with an @ or remove them entirely.

 Reproducing. Not sure how to deactivate it for PHP8, but is an issue.

 Can't find a ticket, already stating this.

--

Comment:

 As the arguments in favour of a function to handle all the checks is
 clear, I think we should handle this in this ticket instead of adding
 overhead by patching three conditions for this issue and then removing it
 shortly after.

 I'm changing this to a Task and widening the scope so that we can discuss
 the addition of a new function to handle this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55711#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform