[wp-trac] [WordPress Trac] #55664: WP post embed: missing labels and duplicate IDs

[WordPress Trac]

#55664: WP post embed: missing labels and duplicate IDs
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Embeds                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  refresh                                        |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch needs-
     refresh
 * milestone:  Future Release => Awaiting Review


Comment:

 Thanks for the insight @swissspidy. I'd rather keep it simple. After all,
 the worst (very unlikely) thing that can happen is a missing association
 between labels and input fields.

 To me, something like `'some-prefix' . wp_rand()` would be enough.
 Thoughts?

 I see the iframe  unique secret is generated with `wp_generate_password(
 10, false )` but that seems a bit overkill to me. Also, I'd rather avoid
 using JavaScript. Other approaches used in core, see combinations of
 various functions e.g. `md5( 'some-string' . time() . wp_rand() )` seem
 definitely overkill.

 Please, let's keep the milestone to 'awaiting review' for now, so the
 accessibility team can review this ticket during their next bug scrub,
 especially for part related to the missing labels.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55664#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform