[wp-trac] [WordPress Trac] #54239: tests for wp_fuzzy_number_match

WordPress Trac noreply at wordpress.org
Thu Mar 31 07:22:12 UTC 2022


#54239: tests for wp_fuzzy_number_match
-------------------------------------------------+-------------------------
 Reporter:  pbearne                              |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.0
Component:  Build/Test Tools                     |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     refresh


Comment:

 I have left a review on the PR which suggests changes for:

 - Consistency in the test suite.
 - Stricter assertions.
 - Ensuring that dataset keys show correctly when using the `--testdox`
 parameter.
 - More datasets.

 Most of these changes are very quick to make and can be landed in 6.0.

 Additional datasets will take some thought, so these could be added later
 if they need more consideration.

 @pbearne let us know whether you have time to work on the requested
 changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54239#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list