[wp-trac] [WordPress Trac] #56029: .git-blame-ignore-revs causes other revisions to be ignored

WordPress Trac noreply at wordpress.org
Tue Jun 21 21:20:39 UTC 2022


#56029: .git-blame-ignore-revs causes other revisions to be ignored
------------------------------+-----------------------------
 Reporter:  johnbillion       |      Owner:  (none)
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Build/Test Tools  |    Version:  6.0
 Severity:  normal            |   Keywords:
  Focuses:                    |
------------------------------+-----------------------------
 Previously: #55422

 It appears that the `.git-blame-ignore-revs` file is causing revisions
 other than those listed to be ignored when using the "View blame prior to
 this change" button on GitHub. This might be a bug in GitHub or it might
 be a side effect of how Git ignores revisions and produces an inability to
 keep track of changes to a line across major changes.

 **Steps to reproduce:**

 * [https://github.com/wordpress/wordpress-develop/blame/trunk/src/wp-
 includes/pluggable.php#L946 Visit the blame view for wp-
 includes/pluggable.php on GitHub]
 * One line 946 you'll see:
 {{{#!php
 list( $username, $expiration, $token, $hmac ) = $cookie_elements;
 }}}
 * Observe the previous revision for this line is listed as
 [https://github.com/WordPress/wordpress-
 develop/commit/78a2c0f78152ab52047937daeba44a55ed71f64a 78a2c0f] which is
 [8696] from the year 2008

 The actual previous revision was [https://github.com/wordpress/wordpress-
 develop/commit/8f95800d52c1736d651ae6e259f90ad4a0db2c3f the Code is Poetry
 commit] ([42343]) which is listed in `.git-blame-ignore-revs`. Prior to
 this commit, there was [https://github.com/wordpress/wordpress-
 develop/commit/97fcbef707e9e853e0ef655fb3aaab192058fee1 97fcbef] ([29221])
 which is an actual functional change which is being ignored.

 Removing the code formatting and pinking commits from the blame views is
 useful, but preventing history from being accurately traced back is a
 problem.

 **Options:**

 * Ask GitHub to investigate or advise
 * Remove the `.git-blame-ignore-revs` file for now

 cc @helen

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56029>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list