[wp-trac] [WordPress Trac] #55840: Internationalization support for sizes added by 'edit_custom_thumbnail_sizes' filter

WordPress Trac noreply at wordpress.org
Wed Jun 15 01:58:24 UTC 2022


#55840: Internationalization support for sizes added by
'edit_custom_thumbnail_sizes' filter
-------------------------+---------------------
 Reporter:  tmatsuur     |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  6.0.1
Component:  Media        |     Version:  6.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------

Comment (by tmatsuur):

 Replying to [comment:4 audrasjb]:
 > Hey there, thanks for the PR @mukesh27!
 >
 > Since `get_intermediate_image_sizes()` also calls
 `wp_get_additional_image_sizes()` which return custom sizes with their
 label, shouldn't we change a bit the existing code to make sure custom
 sizes are also labelled with their translated label (when it exists)?

 When extending the functionality of the `get_intermediate_image_sizes()`,
 I am concerned about the possibility of unintended rewriting by the
 "intermediate_image_sizes" filter.

 I don't think you have to worry about that if you have a new function.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55840#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list