[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file

[WordPress Trac]

#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
----------------------------+-------------------------------
 Reporter:  hztyfoon        |       Owner:  audrasjb
     Type:  defect (bug)    |      Status:  reviewing
 Priority:  low             |   Milestone:  6.1
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by costdev):

 Taking a snippet from a review comment I left on the PR:

 IMO, it's reasonable to expect a reader won't think:
 `30 milliseconds : 3 milliseconds` or `30 minutes : 3 minutes`.

 Instead, for known values, I'd suggest that we only make use of
 `MINUTE_IN_SECONDS` when the value exceeds `59` seconds.

 i.e. `15`, `30`, `55`, `MINUTE_IN_SECONDS`, `2 * MINUTE_IN_SECONDS`, `30 *
 MINUTE_IN_SECONDS`, `HOUR_IN_SECONDS`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform