[wp-trac] [WordPress Trac] #56186: get_page_of_comment doesn't work on descending order for comments

WordPress Trac noreply at wordpress.org
Mon Jul 11 05:33:34 UTC 2022


#56186: get_page_of_comment doesn't work on descending order for comments
--------------------------+------------------------------
 Reporter:  ali11007      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Comments      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by christinavoudouris):

 Thanks for checking in. I'm a new contributor looking to help how I can,
 and am not too familiar with the codebase. I did consider your entire
 post, but I'm not sure how to do what you're describing. I do know
 programming fundamentals, though.

 If you can write out the code you want, and where, I can work with you to
 add another commit to this PR.

 Replying to [comment:3 ali11007]:
 > Replying to [comment:2 christinavoudouris]:
 > > Hey, so I thought this would be a quick fix but many checks pertaining
 to unit tests were not successful. I don't really have experience writing
 tests unfortunately...and am open to other suggestions.
 > Hi @christinavoudouris
 > I saw your commit, you just changed **before** to **after**. But it had
 to be conditional.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56186#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list