[wp-trac] [WordPress Trac] #54910: 5.9 Bug - Blank Home Page

[WordPress Trac]

#54910: 5.9 Bug - Blank Home Page
--------------------------------------+------------------------------
 Reporter:  cantuaria                 |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Themes                    |     Version:  5.9
 Severity:  major                     |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by manfcarlo):

 Replying to [comment:39 ironprogrammer]:
 > I think @costdev's PR appropriately addresses the underlying issue, key
 to which is fixing compatibility with classic and hybrid themes that
 validly use `(block-)templates/index.html` files. (Thank you to everyone
 who has supplied input on the complexity here.)
 >
 > As noted, [https://make.wordpress.org/themes/handbook/review/required
 /theme-tags/#features-tags `Tag: full-site-editing` already exists], so
 any future supports requirements will have this as an option, if needed.
 >
 > But by not ''requiring'' explicit FSE registration, this update is
 consistent with the "no code" future envisioned for theme building, and
 accommodates old and new themes.
 >
 > Kudos for the variations in the unit tests, as well a raising the issue
 on Gutenberg!

 I don't agree. As a plugin developer, I often look at the source code of
 core methods to ascertain what they are doing. This patch turns a fairly
 readable method into something that looks quite mystifying and difficult
 to make sense of. Admittedly, the flowchart helps somewhat, and could be
 linked in the documentation, but I'm not convinced that the complexity is
 unavoidable here.

 I also think checking tags is a mistake. Tags are for compatibility with
 the theme directory, which not all themes need/want to be compatible with.
 It doesn't appear that a precedent exists in core, as case-sensitive
 searches through core files for `['Tags']` and `["Tags"]` yielded no
 results. Plus, it duplicates exactly the same issue at hand, by assuming
 that any theme that happens to have a `full-site-editing` tag is a block
 theme.

 It would not be correct to imply that this confusing flowchart-based
 approach is the only alternative to explicit registration. I would
 appreciate your consideration on my `scandir` [#comment:38 suggestion
 above.]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54910#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform