[wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password

[WordPress Trac]

#54690: Add ability to filter whole notification email in retrieve_password
-------------------------------------------------+-------------------------
 Reporter:  connapptivity                        |       Owner:  audrasjb
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.0
Component:  Users                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:  docs
  note                                           |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Great work so far! I would like to suggest a couple of minor improvements
 :)

 * For consistency with some similar filters like
 `send_password_change_email` or `send_email_change_email`, and for more
 flexibility, should the new `send_retrieve_password_email` filter receive
 the `$user_login` and `$user_data` parameters as well?
 * For consistency with the `retrieve_password_title` and
 `retrieve_password_message` filters, could we pass the additional
 parameters for `retrieve_password_notification_email` directly, instead of
 a compacted array? I see this was discussed on the PR, but I think
 consistency with the existing filters might be beneficial here.

 [attachment:"54690.diff"] implements the suggested changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform