[wp-trac] [WordPress Trac] #54804: String for "Light" has different contexts in Chinese
WordPress Trac
noreply at wordpress.org
Tue Jan 18 08:07:42 UTC 2022
#54804: String for "Light" has different contexts in Chinese
------------------------------------------------+-----------------------
Reporter: ironprogrammer | Owner: audrasjb
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.9
Component: I18N | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch dev-feedback fixed-major | Focuses:
------------------------------------------------+-----------------------
Comment (by SergeyBiryukov):
Replying to [comment:12 hellofromTonya]:
> As these strings were not introduced in 5.9 and 5.9 is in the RC cycle,
I'm hesitant to do the backports. Deferring to @SergeyBiryukov or another
committer with i18n expertise to provide guidance.
If I understand correctly, for 5.9 this is already solved in [52596],
which includes [https://github.com/WordPress/gutenberg/pull/37939 PR
37939] from Gutenberg.
Adding context to either one of the strings (done in the PR above) solves
the issue, so I think [52588] is no longer strictly necessary at all. If
we'd like to keep it for 6.0 just in case, I would suggest a couple of
changes:
* Let's change the context to `color scheme`, as I think the string is
more about the color scheme of a theme than any particular color.
* Let's add the same context to the "Dark" string too, for consistency.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54804#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list