[wp-trac] [WordPress Trac] #56057: Add conditional to WP_Upgrader::install_package() for Rollback testing

[WordPress Trac]

#56057: Add conditional to WP_Upgrader::install_package() for Rollback testing
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  task (blessed)   |      Status:  reopened
 Priority:  normal           |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  6.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+-----------------------------

Comment (by costdev):

 > If the intent of this filter is to be a get-out-of-jail-free card for VB
 users then I am more reluctant to have it in core.

 To be fair, the PR explains that this wasn't the intent of this filter:

 > Instead of the custom conditional for testing Rollback, add a filter
 hook that enables the ability to use custom code in place of copy_dir() in
 WP_Upgrader::install_package(). If the filter returns the default, false,
 then the default copy_dir() will be used.

 i.e. To avoid having code in Core that specifies a feature plugin, and
 instead using established Core extensibility features to enable extenders
 (including feature plugins) to replace functionality where required.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56057#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform