[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

[WordPress Trac]

#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |
-------------------------------------------------+-------------------------

Comment (by schlessera):

 == Test Report

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/3732

 === Environment
 * OS: Linux version 5.15.79.1-microsoft-standard-WSL2 on Windows 11 with
 Ubuntu 20.04.4 LTS
 * Web Server: Built-in PHP Server using `wp server`
 * PHP: 7.4.30
 * WordPress: 6.1.1
 * WP-CLI: 2.7.1
 * Active Plugins:
   * fake-wordpress-update (see
 https://gist.github.com/hellofromtonya/bb0aa2d4b2311c8b40fa5ae8ada4dc19)

 === Steps to Test
 I've followed the test instructions outlined here:
 https://gist.github.com/hellofromtonya/bb0aa2d4b2311c8b40fa5ae8ada4dc19

 I used WP-CLI to set everything up and used WP-CLI to trigger the update
 and test its results.

 === Actual Results

 - ✅ Upgrade via [https://wp-cli.org WP-CLI].

 {{{#!bash
 $ wp core update
 Updating to version 6.1.1-with-requests2 (en_US)...
 Using cached file '/home/alain/.wp-cli/cache/core/wordpress-with-
 requests-2-en_US.zip'...
 Unpacking the update...
 requests_auth was preloaded.
 requests_hooker was preloaded.
 requests_proxy was preloaded.
 requests_transport was preloaded.
 requests_cookie was preloaded.
 requests_exception was preloaded.
 requests_hooks was preloaded.
 requests_idnaencoder was preloaded.
 requests_ipv6 was preloaded.
 requests_iri was preloaded.
 requests_response was preloaded.
 requests_session was preloaded.
 requests_ssl was preloaded.
 requests_auth_basic was preloaded.
 requests_cookie_jar was preloaded.
 requests_proxy_http was preloaded.
 requests_response_headers was preloaded.
 requests_transport_curl was preloaded.
 requests_transport_fsockopen was preloaded.
 requests_utility_caseinsensitivedictionary was preloaded.
 requests_utility_filterediterator was preloaded.
 requests_exception_http was preloaded.
 requests_exception_transport was preloaded.
 requests_exception_transport_curl was preloaded.
 requests_exception_http_304 was preloaded.
 requests_exception_http_305 was preloaded.
 requests_exception_http_306 was preloaded.
 requests_exception_http_400 was preloaded.
 requests_exception_http_401 was preloaded.
 requests_exception_http_402 was preloaded.
 requests_exception_http_403 was preloaded.
 requests_exception_http_404 was preloaded.
 requests_exception_http_405 was preloaded.
 requests_exception_http_406 was preloaded.
 requests_exception_http_407 was preloaded.
 requests_exception_http_408 was preloaded.
 requests_exception_http_409 was preloaded.
 requests_exception_http_410 was preloaded.
 requests_exception_http_411 was preloaded.
 requests_exception_http_412 was preloaded.
 requests_exception_http_413 was preloaded.
 requests_exception_http_414 was preloaded.
 requests_exception_http_415 was preloaded.
 requests_exception_http_416 was preloaded.
 requests_exception_http_417 was preloaded.
 requests_exception_http_418 was preloaded.
 requests_exception_http_428 was preloaded.
 requests_exception_http_429 was preloaded.
 requests_exception_http_431 was preloaded.
 requests_exception_http_500 was preloaded.
 requests_exception_http_501 was preloaded.
 requests_exception_http_502 was preloaded.
 requests_exception_http_503 was preloaded.
 requests_exception_http_504 was preloaded.
 requests_exception_http_505 was preloaded.
 requests_exception_http_511 was preloaded.
 requests_exception_http_unknown was preloaded.
 Warning: Checksums not available for WordPress 6.1.1-with-
 request-v2/en_US. Please cleanup files manually.
 Success: WordPress updated successfully.
 }}}

 Both upgrade and downgrade work as expected with one caveat: the `wp-
 includes/Requests/src` folder is not removed on downgrading.

 === Observations

 I tested this together with @jrf, and so far, our assumption is that the
 approach is sound and works fine, but that there is still an edge case
 that is not handled correctly on Mac OS X. Given that this system has a
 very peculiar filesystem regarding the handling of case sensitivity, my
 current bet is that there's an unlucky interaction between the case
 sensitivity of the autoloader and that of the filesystem here that breaks
 for Macs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:98>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform