[wp-trac] [WordPress Trac] #57318: Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php
WordPress Trac
noreply at wordpress.org
Mon Dec 12 12:19:21 UTC 2022
#57318: Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php
------------------------------------------+-------------------------------
Reporter: jenilk | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing-info | Focuses: coding-standards
------------------------------------------+-------------------------------
Comment (by jenilk):
Replying to [comment:1 johnbillion]:
> Thanks for the patch @jenilk! Are all of these variables guaranteed to
be of the same type? For example data coming in via `$_POST` may be a
string, etc.
@johnbillion - I made changes to the 4 places, and out of them, there are
2 places where the data is coming as **$_POST** for comparison. We can not
be guaranteed of it will be of the same type(FYI we don't have declared
variable with datatype specification).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57318#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list