[wp-trac] [WordPress Trac] #57293: Twenty Twenty-One: Incorrect Mastodon domain (mastodon.com) for Social Icon in Footer Menu
WordPress Trac
noreply at wordpress.org
Fri Dec 9 03:04:52 UTC 2022
#57293: Twenty Twenty-One: Incorrect Mastodon domain (mastodon.com) for Social Icon
in Footer Menu
---------------------------+------------------------------
Reporter: triumvirate | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: 5.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
---------------------------+------------------------------
Comment (by triumvirate):
No problem — I totally understand the maintenance concerns, especially as
they likely fall on possibly uncompensated open source contributors (such
as yourself?) who might have to field inquiries about such and such far-
flung instance domain about "why isn't this one supported while this other
one is?" far after I myself have walked away satisfied.
> Are you willing to assist with starting a discussion on
make.wordpress.org/core -- it's the best spot to form policy such as this?
Absolutely!
I can try to enumerate those statistics as well for the 34 I selected
above (
> How long has the server been active for?
> How many users does the server have, what percentage are active?
> How many toots are sent on a daily basis?
)
towards that end?
Also, I'm definitely open to workarounds; please let me know if you have a
sense of whether this could (should?) be done as an add-on instead of in
the theme -- I'm not familiar with what goes where, to be honest.
Relatedly, also, I saw that maybe it's possible to modify `functions.php`
with existing add-ons? I don't see a way to do that for this, though, to
be honest, because looks like we'd basically have to monkey-patch the
instance variable of `wp-content/themes/twentytwentyone/inc/menu-
functions.php::Twenty_Twenty_One_SVG_Icons` which might be private from
the perspective of `wp-includes/functions.php`? (excuse my Pythonic
terminology here, haven't really used PHP).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57293#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list