[wp-trac] [WordPress Trac] #56468: sanitize_option() does not handle deprecated timezones correctly

[WordPress Trac]

#56468: sanitize_option() does not handle deprecated timezones correctly
----------------------------------------------------+---------------------
 Reporter:  jrf                                     |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.1
Component:  Options, Meta APIs                      |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  has-patch needs-testing has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by jrf):

 I've opened [https://github.com/WordPress/wordpress-develop/pull/3155
 GitHub PR#3155] to address this issue.

 > I'll test the patch when it's up

 @costdev I look forward to your feedback!

 > Boop: tear_down() contains the line: $wpdb->query( 'ROLLBACK' );.
 Commented out to confirm it's the specific point where it's cleared - and
 it is.

 Interesting for sure, but that doesn't explain why I still saw problems
 running the tests in isolation. Either way, the "resetting of the options
 in test fixture" bit is in a separate commit, so could be dropped if it
 turns out to not be needed, though there is "prior art" for the same.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56468#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform