[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53945" 53945]:
 {{{
 #!CommitTicketReference repository="" revision="53945"
 Code Modernization: Remove unused dynamic property in
 `WP_Test_REST_Pages_Controller`.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 In this case, it appears that the dynamically created
 `$has_setup_template` property is not actually used. It is unclear what
 the original intention was, but since it is undeclared and unused, it can
 be safely removed.

 Follow-up to [38832], [53557], [53558], [53850], [53851], [53852],
 [53853], [53854], [53856], [53916], [53935], [53936], [53937], [53938],
 [53942].

 Props jrf, antonvlasenko.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:84>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform