[wp-trac] [WordPress Trac] #56386: Remove `@access private` from cache priming functions.

WordPress Trac noreply at wordpress.org
Thu Aug 25 00:27:33 UTC 2022


#56386: Remove `@access private` from cache priming functions.
----------------------------------------+------------------------------
 Reporter:  peterwilsoncc               |       Owner:  (none)
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Cache API                   |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  performance
----------------------------------------+------------------------------

Comment (by peterwilsoncc):

 A precedent I found in [46602] for #48251 retained the unnderscore prefix
 while removing the private delegation.

 In the previous ticket, the functions in question appeared 13249 times in
 the plugin repo. In this case the functions in question appear 237 times
 in the plugin plugin repo. The most frequently used
 [https://wpdirectory.net/search/01GB95XVZH2GKMK5AGYB8G6ZA7 being post
 priming] in some 5M+ installed plugins.

 I can be convinced either way but worry deprecating the functions would
 create a lot of noise in logs to avoid a precedent that has already been
 set.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56386#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list